.NET Tip: Comparing Strings Safely

CodeGuru content and product recommendations are editorially independent. We may make money when you click on links to our partners. Learn More.

You often need to compare strings (or other data types), but sometimes a value could be null or DBNull if it’s coming from the database. The built-in C# comparison functions don’t handle nulls properly, so I wrote a couple of functions to take care of this for me.

This function, and its overloaded version, compare the string value of an object and another string:

private bool SafeCompare(object test, string testValue)
{
   return SafeCompare(test, testValue,
                      StringComparison.CurrentCultureIgnoreCase);
}

private bool SafeCompare(object test, string testValue,
                         StringComparison compareSetting)
{
   if (test != null)
   {
      if (!Convert.IsDBNull(test))
      {
         return String.Compare(test.ToString(), testValue,
                               compareSetting) == 0;
      }
      else
       return false;
   }
   else
      return false;
}

The function first tests the object against null, then against DBNull, and then against the string in question. Any null/DBNull value will cause the function to return false. The overloaded version also allows you to default the StringComparison value, which enables you to specify case-sensitive or case-insensitive comparisons. I prefer to do a case-insensitive comparison in most cases, so that’s the default value I send if that parameter is omitted.

Using this function as a model, you could easily add other overloads for non-string data types, such as doubles or integers. Here’s a version for comparing two integers “safely”:

private bool SafeCompare(object test, integer testValue)
{
   if (test != null)
   {
    if (!Convert.IsDBNull(test))
    {
      return Convert.ToInt32(test) == testValue;
   }
   else
      return false;
   }
   else
      return false;
}

Because the parameter types are different, you can add this overloaded version to the other two shown above. This saves a lot of duplicated code and works around the inability to deal with nulls without throwing exceptions.

About the Author

Eric Smith is the owner of Northstar Computer Systems, a Web-hosting company based in Indianapolis, Indiana. He is also a MCT and MCSD who has been developing with .NET since 2001. In addition, he has written or contributed to 12 books covering .NET, ASP, and Visual Basic. Send him your questions and feedback via e-mail at questions@techniquescentral.com.